Resolve Pitest Issues - AvoidStarImportCheck (2)

[rnveach]

Child issue of #7797 ,

This issue specifically focuses on the line

checkstyle/.ci/pitest.sh

Line 75 in abf829f

"AvoidStarImportCheck.java.html:<td class='covered'><pre><span class='survived'> if (exclude.endsWith(STAR_IMPORT_SUFFIX)) {</span></pre></td></tr>"

[HuGanghui]

I am on it

[HuGanghui]

Pitest report

Link: https://huganghui.github.io/7800-AvoidStarImportCheck(2)/before-pit-reports/202003131405/
Surviving mutations:
on line 188: removed conditional - replaced equality check with false → SURVIVED I am focusing on it.
on line 224: removed conditional - replaced equality check with true → SURVIVED referenced by #7799, wilcoln is focusing on it.

Hardcoded mutation

mutation cs branch: HuGanghui@1578ac0
comment:
Looking at the pitest report, we can see that the surviving mutation is the one for which removed conditional - replaced equality check with false → SURVIVED, this is equivalent as simply removing the entire condition and keeping only the else body. Which I did.

Regression diff report

Used only guava and elastic-search, but there is no diff found.
Link: https://huganghui.github.io//7800-AvoidStarImportCheck(2)/hardcoded-reports/diff/

Code Logic Analysis
Although there is no diff found in Regression diff report, I find that the reason why the surviving mutation exists is maybe a small oversight in an existing UT , details as follows:

checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportCheckTest.java

Line 63 in 91f13c1

"java.io,java.lang,javax.swing.WindowConstants.*, javax.swing.WindowConstants");

javax.swing.WindowConstants is redundant in this UT, so I remove this import and do Pitest, report shows it can kill the mutation.

[wilcoln]

Hi bro,
You might want to remove the following part of my comment from yours because it doesn't apply to your case.

.. , this is equivalent as simply removing it. Which I did, leaving us with only the second condition...

I believe what you want to say is

.. , this is equivalent as simply removing the entire condition and keeping only the else body. Which I did.

[HuGanghui]

@wilcoln ok, Thanks~, your statement is more accurate.

[strkkk]

Fix is merged.