Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue with file.lastModified() #6096

Closed
Bananeweizen opened this issue Aug 30, 2018 · 3 comments
Closed

Performance issue with file.lastModified() #6096

Bananeweizen opened this issue Aug 30, 2018 · 3 comments
Labels
approved miscellaneous
Milestone
8.15

Comments

@Bananeweizen
Copy link
Contributor

Checkstyle checks the file time stamp to avoid checking an unmodified file again. At least on Windows, this can be quite costly. On a project with about 300.000 LOC Yourkit tells me that I spend almost a minute in File.lastModified().

This can be improved by not querying the timestamp as the first cancellation condition in the Checker at https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/Checker.java#L277, but only as late as possible. First we should check cancellation by name.
Bananeweizen added a commit to Bananeweizen/checkstyle that referenced this issue Aug 30, 2018
@Bananeweizen
Issues checkstyle#6096: Improve performance of modification check
3362c77 
First check whether this file shall be checked by file name extension,
only afterwards check the file timestamp. This can avoid the timestamp
access in some cases.
Bananeweizen added a commit to Bananeweizen/checkstyle that referenced this issue Aug 30, 2018
@Bananeweizen
Issue checkstyle#6096: Improve performance of modification check
1e948db
@Bananeweizen Bananeweizen mentioned this issue Aug 30, 2018
Closed
@rnveach
Copy link
Member

rnveach commented Aug 30, 2018 •
edited

@romani I am fine with this. Please review.

@romani romani added the approved label Sep 9, 2018
@romani
Copy link
Member

romani commented Sep 9, 2018

issue is approved, it is reasonable to be lazy in calculations.

rnveach pushed a commit to Bananeweizen/checkstyle that referenced this issue Nov 3, 2018
@Bananeweizen @rnveach
Issue checkstyle#6096: Improve performance of modification check
dbccb17
romani added a commit that referenced this issue Nov 25, 2018
@romani
Issue #6096: improve performance with not lazy usage of file.lastModi…
0c13437 
…fied()
@romani romani mentioned this issue Nov 25, 2018
Merged
romani added a commit that referenced this issue Nov 27, 2018
@romani
Issue #6096: improve performance with not lazy usage of file.lastModi…
ba435b8 
…fied()
@romani romani added this to the 8.15 milestone Nov 27, 2018
@romani
Copy link
Member

romani commented Nov 27, 2018

fix is merged.

@romani romani closed this as completed Nov 27, 2018
tsunghanjacktsai pushed a commit to tsunghanjacktsai/checkstyle that referenced this issue Dec 3, 2018
@romani @tsunghanjacktsai
Issue checkstyle#6096: improve performance with not lazy usage of fil…
829e966 
…e.lastModified()
tsunghanjacktsai pushed a commit to tsunghanjacktsai/checkstyle that referenced this issue Dec 3, 2018
@romani @tsunghanjacktsai
Issue checkstyle#6096: improve performance with not lazy usage of fil…
ecb5ab1 
…e.lastModified()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
8.15
Development

No branches or pull requests
3 participants
@Bananeweizen @romani @rnveach