-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http://checkstyle.sourceforge.net ==> http://checkstyle.org #5601
Comments
Would someone with the appropriate persmissions like to move my proposed and corretly configured https://github.com/vorburger/checkstyle.github.io under https://github.com/checkstyle? I obviously cannot do this myself (You don’t have the permission to create repositories on checkstyle.), so I'm guessing you have to either fork my repo into that (but that's ugly and will keep the "forked from vorburger" forever, which could be confusing in the future), or perhaps temporarily grant me that permission, let me move it, and then take that permission away again?
AFAIK you would have to do both this and then this DNS config. I'm happy to help out with that, if you like. The goal is to see if we will see this test index.html on http://checkstyle.org and http://www.checkstyle.org Background:
|
@vorburger , I appreciate your desire to help. I will try to be responsive to your contributions, but I apologize in advance as there are already a lot of people are awaiting for response from me. I am ok to pin me and remind me to respond.
I do not have it now.
it will stay in play till github.io web site become complete mirror of content and we found way to do automatic way to release to it. I do not expect it will be very quick, too much items to move and recheck. There are lot of nuances stick to hosting for last 17 years.
completely separate and more complicated issue, lets just migrate to new hosting and all other improvements should be done as post steps.
It is also complicated issue, please do not even try to make it in scope of this issue, we discussed it hundreds of times, there are problems and nuances, it is not that simple but doable, and we did a lot as prestep for this. Lets not discuss this topic in this issue, let create separate if we do not have yet.
I might do creation of repo, just copy content, so all further updates will be by PRs as usually. |
Otherwise, someone could also just a new domain, of course.
that sounds like a great plan to me.
Whatever works for you works for me. Not sure which repo you mean now (checkstyle or checkstyle.github.io ?), but I'm actually not even asking for RW access to any repo. The only thing that should ever write to checkstyle.github.io is a build job IMHO. |
Thanks @vorburger for going forward with this!
Fwiw, I vote for a new repo like www.checkstyle.org under this org, as this will help reduce the disk size of the checkstyle repo for people that don't work on the website. |
it will not help, website is generated from files of xdoc folder of repo, content is minimal in comparison to other files. Redo website to new engine is completely different issue, and far more complicated, but doable. |
@romani I believe you misunderstood the point that @tsjensen is trying to make - he's agreeing with having a new repo instead of using the "gh-pages" branch of this repo saves .git space in this repo, especially if we have a job that push latest (generated from xdoc as is, yes) content to it. I agree with this, and I believe you also have implicitly above, and that is why I proposed checkstyle.github.io. FYI if I understand how GitHub Pages work correctly, that repo HAS to be called exactly that, not e.g. www.checkstyle.org, because GitHub pages triggers for repo named ORGNAME.github.io. |
Yes, as branch it will never be in main repo, it is old fashioned approach of GitHub pages, right now GitHub allow to use special repo for this.
It is ok to have it like this while we try to migrate. |
I purchased checkstyle.org |
neat. Now you would have to do both this and then this DNS config, somewhere in DNS configuration for this domain at GoDaddy. Shout if you need any help with that. |
github.io pages repo is created - https://github.com/checkstyle/checkstyle.github.io |
@vorburger , it is not clear to me, why it redirects to your webpage ? from https://help.github.com/articles/troubleshooting-custom-domains/
please remove/change your CNAME file at https://github.com/vorburger/checkstyle.github.io . |
as discussed in checkstyle/checkstyle#5601 (comment) now that there is a https://github.com/checkstyle/checkstyle.github.io
done in vorburger/checkstyle.github.io@fc67ee9, but GitHub may take a moment to realize it - let's give it some time. |
It works now, http://checkstyle.org . |
Looks like eclipse-cs automatically become to use new domain. So we need to be accurate with domain as it is already become in use by eclipse-cs, domain is for whole organization, and eclipse-cs part of it. |
@romani , @vorburger let me help with this migration. I believe I have enough rights and knowledge on Checkstyle SourceForge and GitHub to move everything properly. |
One nuance will be with DTD files that are currently hosted on Sourceforge. The DTD files are referenced in people Checkstyle configs all over the world so we need to make sure we will not remove them from SourceForge as that would break the process for thousands of Checkstyle users. I wonder if on SourceForge we can setup a reliable redirect for these DTDs pointing to github.io |
…om Sourceforge to Github IO see checkstyle/checkstyle#5601
PR checkstyle/checkstyle.github.io#1 adds the fresh-generated Maven site (totally 11.6 Mb in ~5k files) to GitHub.io. All pages seems to be generated properly, but @romani could you please review? Here is a link to test it out on my fork: https://daniilyar.github.io/checkstyle.github.io/ |
…om Sourceforge to Github IO see checkstyle/checkstyle#5601
…aven-generated site from Sourceforge to Github IO
…aven-generated site from Sourceforge to Github IO
The current SSL certificate is not valid for checkstyle.org so we can't use https properly. This should be fixed! |
one more reason to move out of sourceforge, long down time today, this affects circleCIs unfortunately:
|
reason of delay in release 8.12 :
|
sourceforge.net ssh access is not working again .... make a delay in 8.15 release. One of approach to deploy only to github.io is
in all cases it will require small changes in |
checkstyle.org is now main web site , sourceforce is mirror if it works. Still not done:
|
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closes #23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit c5de804) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closes #23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit c5de804) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closes #23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closes apache#23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit c5de804) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closes apache#23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit c5de804) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closes apache#23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit c5de804) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
## What changes were proposed in this pull request? Below build failed with Java checkstyle test, but instead of violation it shows FileNotFound on dtd file. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102751/ Looks like the link of dtd file is dead `http://www.puppycrawl.com/dtds/configuration_1_3.dtd`. This patch updates the dtd link to "https://checkstyle.org/dtds/" given checkstyle repository also updated the URL path. checkstyle/checkstyle#5601 ## How was this patch tested? Checked the new links. Closes #23887 from HeartSaVioR/java-checkstyle-dtd-change-url. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit c5de804) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit b031f4a)
I am closing this epic issue, #7377 is leftover that we need to think about. |
Follow-up from #5574 (which I'll close) :
Reading https://sourceforge.net/p/forge/site-support/16482/, I get the feeling that it's probably a good time now for another step to move CS away from sourceforge.net? @romani in #5574 said, quote:
so I propose this issue to move the website that is currently on http://checkstyle.sourceforge.net to http://[wwww.]checkstyle.org. This should hopefully be possible using GitHub pages - I've done this myself for a few of my projects, and am willing to find the time to make a (small!) contribution to CS to help get this set up.
Just for the purpose of containing scope and have "actionable" issue, I also propose that this issue is strictly limited to moving the static content that today is on http://checkstyle.sourceforge.net, exactly as it is, over to a checkstyle.org.
We probably should have the discussion about what to the with the existing site - HTTP redirects? At root? On every page??
But IMHO we should use other new issues for any discussion related to "a good opportunity to revamp the site as well, as it is a bit dated." and "propose using a more modern static site generator like Jekyll (which integrates well with GitHub Pages). The upshot of doing it this way would be that the site content could just be (mostly) written with Markdown instead of xdoc." (@ntsim) nor "release uploads" related stuff (@misery) - I can only encourage anyone with bandwith to help driving those possible follow ups to this issue in new issues (which I personally will not have the capacity to help with).
So I think what that this boils down to is just (a) do a test to confirm we can host content on checkstyle.org using GitHub pages (test that CNAME thing we'll have to do), and then (b) get the Travis CI master build job to push the output produced by "mvn clean site" to where we ended up hosting the generated content for checkstyle.org - which I'm guessing will either be the "gh-pages" branch of this repo, or a new repo like www.checkstyle.org under this org; what's easier, anyone?
@romani can you confirm that you have DNS control over checkstyle.org ?
The text was updated successfully, but these errors were encountered: