Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #13345: Enable example tests for SingleLineJavadocCheckExamples… #14871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue #13345: Enable example tests for SingleLineJavadocCheckExamples… #14871

wants to merge 1 commit into from

Conversation

prathm3
Copy link
Contributor

@prathm3 prathm3 commented May 9, 2024 •
edited

Issue: #13345

Enabled tests for SingleLineJavadocCheckExamplesTests.java

@romani
Copy link
Member

romani commented May 9, 2024

@prathm3, , please execute mvn verify on your local before pushing to PR.
If you have problems with execution of this command, please let us know, we can help.

@prathm3 prathm3 force-pushed the EnableSingleLineJavadocCheckExamples branch 4 times, most recently from 14d33a8 to 13ed612 Compare May 10, 2024 19:00
@romani
Copy link
Member

romani commented May 10, 2024

We need this changes in commit https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=21400&view=logs&j=c902ebb4-c9f8-5f09-4e17-ff78fbbc842e&t=9ca98c81-ff64-58f0-9d03-a23ac1c4a111&l=1800

Just put in commit all that are changed on your local after mvn verify.

@prathm3 prathm3 force-pushed the EnableSingleLineJavadocCheckExamples branch 2 times, most recently from b7336e8 to cf17273 Compare May 11, 2024 06:03
@prathm3 prathm3 force-pushed the EnableSingleLineJavadocCheckExamples branch from cf17273 to 2934b40 Compare May 11, 2024 06:57
@prathm3
Copy link
Contributor Author

prathm3 commented May 11, 2024

@romani , thanks for the hint. Failed some checks with Caused by: java.net.ConnectException: Network is unreachable (connect failed). I tried retriggering tests but same error is occurring. ( on local all tests are passing ). Do you think this issue is because of some changes ? ( I have seen some companies turn off some functionality ( jobs ) over weekends, is it same for check style ? )

romani
romani requested changes May 11, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

...les/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/singlelinejavadoc/Example1.java
package com.puppycrawl.tools.checkstyle.checks.javadoc.singlelinejavadoc;
// xdoc section -- start
public class Example1 {
/** @see Math */ // violation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have few possible messages from Check https://checkstyle.org/checks/javadoc/singlelinejavadoc.html#Violation_Messages
it is not clear which violation is here, please add message to this line // violation 'some message' message is regexp so you can provide only most meanigful part of original message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prathm3 @romani