Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github generate site fails to generate links with anchors. #14857

Open
Lmh-java opened this issue May 4, 2024 · 0 comments
Open

Github generate site fails to generate links with anchors. #14857

Lmh-java opened this issue May 4, 2024 · 0 comments
Labels

Comments

@Lmh-java
Copy link
Contributor

Lmh-java commented May 4, 2024

Discovered at #14740 (comment).

In that PR, we've changed the Pattern[] property type. When running GitHub, generate site, #14740 (comment) is returned.

Actual:

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/9f55855_2024115508/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/9f55855_2024115508/checks/imports/importorder.html#Properties

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/9f55855_2024115508/property_types.html#

Expect:

The last link should be

...
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/9f55855_2024115508/property_types.html#Pattern.5B.5D

Reproduce:

  1. Modify the Pattern[] property documentation to make a difference.
  2. Open a PR and run GitHub, generate site.

Analysis:

#14740 (comment).

Edit: From just glancing, it looks like the code is looking at the source for subsection with an id and not section with a name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants