Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable and Monitor YAMLSchemaValidation inspection #14806

Open
MANISH-K-07 opened this issue Apr 18, 2024 · 6 comments
Open

Re-enable and Monitor YAMLSchemaValidation inspection #14806

MANISH-K-07 opened this issue Apr 18, 2024 · 6 comments

Comments

@MANISH-K-07
Copy link
Contributor

MANISH-K-07 commented Apr 18, 2024

Follow-up of #14696 (review)

inspection-results/YAMLSchemaValidation.xml
We had stable failure of inspection validation YAMLSchemaValidation
https://app.circleci.com/pipelines/github/checkstyle/checkstyle/23624/workflows/e04a197a-8172-4262-9fa3-de02579854c4/jobs/506740/artifacts

<problems is_local_tool="true">
<problem>
<file>file://$PROJECT_DIR$/.github/workflows/site.yml</file>
<line>14</line>
<module>project</module>
<entry_point TYPE="file" FQNAME="file://$PROJECT_DIR$/.github/workflows/site.yml"/>
<problem_class id="YAMLSchemaValidation" severity="WARNING" 
      attribute_key="WARNING_ATTRIBUTES">Validation by JSON Schema</problem_class>
<description>Schema validation: Property 'name' is not allowed</description>
<highlighted_element>name: "Site"</highlighted_element>
<language>yaml</language>
<offset>0</offset>
<length>12</length>
</problem>

This problem is a false positive. Facing instability with this inspection, it had been disabled at 65314ea

We have migrated IDEA to highest true scopes release v2022.3.3 at #14696

Hoping that the migration has fixed this problem (#14806 (comment)),
we need to try and re-enable this inspection.

<!-- until #14448 -->
<inspection_tool class="YAMLSchemaValidation" enabled="false" level="ERROR"
enabled_by_default="false"/>

@MANISH-K-07
Copy link
Contributor Author

MANISH-K-07 commented Apr 18, 2024

@romani , @nrmancuso , You can track re-runs of inspections for success/failure at #14808 (comment)

I will keep restarting CI and updating that comment with links until you are satisfied for merge ;)

MANISH-K-07 added a commit to MANISH-K-07/checkstyle that referenced this issue Apr 18, 2024
MANISH-K-07 added a commit to MANISH-K-07/checkstyle that referenced this issue Apr 18, 2024
@MANISH-K-07
Copy link
Contributor Author

Unfortunately, the problem still persists despite migration of IDEA to v2022.3.3 :(
https://output.circle-artifacts.com/output/job/4946fcff-c418-4172-b566-5e343cb6d7b7/artifacts/0/home/circleci/project/target/inspection-results/YAMLSchemaValidation.xml

@romani , what do you suggest we do? Report this to jetBrains?

@nrmancuso
Copy link
Member

nrmancuso commented Apr 18, 2024

what do you suggest we do? Report this to jetBrains?

Unless you can show that it still happens on the latest version, I am not sure if they will give it much attention.

Due to the flakiness of this issue, I have commented elsewhere previously that it may be a network/server problem rather than an actual "bug" in the inspections engine. The yaml schema is downloaded on each execution of inspections.

@MANISH-K-07
Copy link
Contributor Author

MANISH-K-07 commented Apr 18, 2024

Unless you can show that it still happens on the latest version, I am not sure if they will give it much attention.

Honestly, there's been no activity at scopes issue itself despite the fact that it impacts latest releases. Please see IJPL-1068
Me being used to everything getting done so efficiently here at CS, it seems a bit strange that they take so long even after
issue is assigned 😅

I have commented elsewhere previously that it may be a network/server problem rather than an actual "bug" in the inspections engine. The yaml schema is downloaded on each execution of inspections.

@nrmancuso , so how long can we keep it disabled then? Is there any alternative?

@nrmancuso
Copy link
Member

I personally don't care if this stays disabled forever. We can leave this issue open for as long we we need to and come back some other time when it is convenient; this has no user impact.

@romani
Copy link
Member

romani commented Apr 18, 2024

Unfortunately, the problem still persists despite migration of IDEA to v2022.3.3 :(

Please close PR and let's wait for our migration to latest Idea.
This issue is blocked for now

@romani romani added the blocked label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants