New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: shallowClone in checkstyle-tester with SHA checkout #14662
base: master
Are you sure you want to change the base?
Conversation
3d2f371
to
43b2e44
Compare
@nrmancuso, i was trying to test my changes Checkstyle/ for shallow-cloning. But, I assume we need to create a separate testing branch for the same. Is there any other way? |
@relentless-pursuit there are a bunch of ways to test this out, but I would just use your fork of contribution in the |
43b2e44
to
fc69aa1
Compare
Thank you. Your suggestion worked. Currently, analysing the reports. And, I can see |
@relentless-pursuit I am placing blocked label and putting this into draft mode to make it obvious that we don't need to remove this. |
fc69aa1
to
567a502
Compare
567a502
to
7d1fdf4
Compare
af1c0b5
to
c42f2e5
Compare
Rebased to show latest execution results. |
Rebase to show latest execution results. |
@rnveach based on the latest rebasing, i would highlight for your reference: Successfull building while implementing shallow clone: https://app.circleci.com/pipelines/github/checkstyle/checkstyle/25480/workflows/b006820e-4d74-4fba-817f-a5693176a112/jobs/588430
Successful build while retatining checkout to specific SHA: https://app.circleci.com/pipelines/github/checkstyle/checkstyle/25480/workflows/b006820e-4d74-4fba-817f-a5693176a112/jobs/588425
|
Please fix CI problems https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=21366&view=logs&j=c902ebb4-c9f8-5f09-4e17-ff78fbbc842e&t=9ca98c81-ff64-58f0-9d03-a23ac1c4a111&l=1325 After merge of contributions PR, we will merge this PR too, some minor revert for repo name will be required |
@relentless-pursuit, contribution PR is closed, please prepare this PR for merge. Commit prefix should be "Pull #14662: ...." |
b1a2c7a
to
b2bf674
Compare
b2bf674
to
c8a874c
Compare
@romani can you help me understand what needs to be changed in this repo? Also, i used the parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you help me understand what needs to be changed in this repo?
See below.
Items
@@ -895,6 +895,7 @@ no-exception-struts) | |||
sed -i'' 's/#apache-struts/apache-struts/' projects-to-test-on.properties | |||
groovy ./diff.groovy --listOfProjects projects-to-test-on.properties \ | |||
--patchConfig checks-nonjavadoc-error.xml -p "$BRANCH" -r ../../.. \ | |||
--useShallowClone \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 13 usages of diff.groovy please update all of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
c8a874c
to
e3fe324
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge.
Thanks a lot for finishing long update
Issue #818: Aims to see if the shallowClone feature works fine