Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: shallowClone in checkstyle-tester with SHA checkout #14662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

relentless-pursuit
Copy link

@relentless-pursuit relentless-pursuit commented Mar 14, 2024

Issue #818: Aims to see if the shallowClone feature works fine

@relentless-pursuit
Copy link
Author

@nrmancuso, i was trying to test my changes Checkstyle/ for shallow-cloning. But, I assume we need to create a separate testing branch for the same. Is there any other way?

@nrmancuso
Copy link
Member

@relentless-pursuit there are a bunch of ways to test this out, but I would just use your fork of contribution in the checkout_from command

@relentless-pursuit
Copy link
Author

relentless-pursuit commented Mar 14, 2024

@relentless-pursuit there are a bunch of ways to test this out, but I would just use your fork of contribution in the checkout_from command

Thank you. Your suggestion worked. Currently, analysing the reports. And, I can see
ci/circleci: no-exception-Pmd-elasticsearch-lombok-ast report succeeding, while retaining specific checkout option. And, I assume the code was more or less the same, resue of Romani's PR. So, hopefully, I can have some idea if the code changes are working.

@nrmancuso
Copy link
Member

@relentless-pursuit I am placing blocked label and putting this into draft mode to make it obvious that we don't need to remove this.

@romani
Copy link
Member

romani commented May 8, 2024

Rebased to show latest execution results.
@rnveach , fyi

@romani
Copy link
Member

romani commented May 8, 2024

Rebase to show latest execution results.
@rnveach , fyi

@relentless-pursuit
Copy link
Author

relentless-pursuit commented May 8, 2024

@rnveach based on the latest rebasing, i would highlight for your reference:

Successfull building while implementing shallow clone: https://app.circleci.com/pipelines/github/checkstyle/checkstyle/25480/workflows/b006820e-4d74-4fba-817f-a5693176a112/jobs/588430

Testing Checkstyle started
   [delete] Deleting directory /home/circleci/project/.ci-temp/contribution/checkstyle-tester/src/main/java
Shallow clone git repository 'apache-struts' to repositories/apache-struts folder ...
Cloning into 'repositories/apache-struts'...
Cloning git repository 'apache-struts' - completed

Successful build while retatining checkout to specific SHA: https://app.circleci.com/pipelines/github/checkstyle/checkstyle/25480/workflows/b006820e-4d74-4fba-817f-a5693176a112/jobs/588425

Testing Checkstyle started
   [delete] Deleting directory /home/circleci/project/.ci-temp/contribution/checkstyle-tester/src/main/java
Cloning git repository 'pmd' to repositories/pmd folder ...
Cloning into 'repositories/pmd'...
Cloning git repository 'pmd' - completed

Running command: git fetch --tags
Resetting git sources to commit 'pmd_releases/6.21.0'
Running command: git reset --hard refs/tags/pmd_releases/6.21.0
HEAD is now at a28e9e22e5 [maven-release-plugin] prepare release pmd_releases/6.21.0
pmd is synchronized
     [copy] Copying 4019 files to /home/circleci/project/.ci-temp/contribution/checkstyle-tester/src/main/java/pmd
Running 'mvn clean' on src/main/java ...
Running command: mvn -e --no-transfer-progress --batch-mode clean

@romani
Copy link
Member

romani commented May 9, 2024

Please fix CI problems https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=21366&view=logs&j=c902ebb4-c9f8-5f09-4e17-ff78fbbc842e&t=9ca98c81-ff64-58f0-9d03-a23ac1c4a111&l=1325
It is better to have fully green CI, as good sign. Red CI is red flag for all maintainers and suspicious filling is growing .

After merge of contributions PR, we will merge this PR too, some minor revert for repo name will be required

@romani
Copy link
Member

romani commented May 11, 2024

@relentless-pursuit, contribution PR is closed, please prepare this PR for merge.

Commit prefix should be "Pull #14662: ...."

@romani romani marked this pull request as ready for review May 11, 2024 20:24
relentless-pursuit pushed a commit to relentless-pursuit/checkstyle that referenced this pull request May 15, 2024
relentless-pursuit pushed a commit to relentless-pursuit/checkstyle that referenced this pull request May 15, 2024
@relentless-pursuit
Copy link
Author

some minor revert for repo name will be required

@romani can you help me understand what needs to be changed in this repo? Also, i used the parameter useShallowClone in validation.sh.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you help me understand what needs to be changed in this repo?

See below.

Items

@@ -895,6 +895,7 @@ no-exception-struts)
sed -i'' 's/#apache-struts/apache-struts/' projects-to-test-on.properties
groovy ./diff.groovy --listOfProjects projects-to-test-on.properties \
--patchConfig checks-nonjavadoc-error.xml -p "$BRANCH" -r ../../.. \
--useShallowClone \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 13 usages of diff.groovy please update all of them

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@relentless-pursuit
Copy link
Author

@relentless-pursuit, contribution PR is closed, please prepare this PR for merge.

Commit prefix should be "Pull #14662: ...."

Done

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge.

Thanks a lot for finishing long update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants