Relocate AccessModifierOption

[nrmancuso]

Noticed at #12340 (comment), AccessModifierOption

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/AccessModifierOption.java

Line 30 in 276263b

public enum AccessModifierOption {

currently lives in the naming package, but is used elsewhere. This class should be moved to a more general location.

This also causes a lot of ArchUnit violations:

➜  archunit-store git:(issue-12435) ✗ cat slices_should_be_free_of_cycles_suppressions | grep AccessModifierOption | wc -l
47

Here is where we import this class:

➜  checkstyle git:(issue-12435) ✗ ag -lQ "naming.AccessModifierOption" --java      
src/main/java/com/puppycrawl/tools/checkstyle/api/AutomaticBean.java
src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheck.java
src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java
src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheck.java
src/main/java/com/puppycrawl/tools/checkstyle/checks/sizes/RecordComponentNumberCheck.java
src/main/java/com/puppycrawl/tools/checkstyle/utils/CheckUtil.java
src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java
src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsJavaDocsTest.java
src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsPagesTest.java
src/test/java/com/puppycrawl/tools/checkstyle/utils/CheckUtilTest.java

Also, see #3511, where we have an approved issue to replace Scope with AccessModifierOption

We also have a PR hanging to migrate another check to AccessModifierOption: #9277

We should consider moving AccessModiferOption to the api package before fully deprecating Scope, to allow users to migrate.