Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Pitest for Annotation Profile #12329

Closed
Kevin222004 opened this issue Oct 22, 2022 · 3 comments
Closed

Resolve Pitest for Annotation Profile #12329

Kevin222004 opened this issue Oct 22, 2022 · 3 comments

Comments

@Kevin222004
Copy link
Collaborator

Related to #7797

kill mutation

<?xml version="1.0" encoding="UTF-8"?>
<suppressedMutations>
<mutation unstable="false">
<sourceFile>AnnotationUseStyleCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.annotation.AnnotationUseStyleCheck</mutatedClass>
<mutatedMethod>checkStyleType</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.RemoveSwitchMutator_3</mutator>
<description>RemoveSwitch 3 mutation</description>
<lineContent>switch (elementStyle) {</lineContent>
</mutation>

and
<mutation unstable="false">
<sourceFile>SuppressWarningsCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.annotation.SuppressWarningsCheck</mutatedClass>
<mutatedMethod>visitToken</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.RemoveSwitchMutator_0</mutator>
<description>RemoveSwitch 0 mutation</description>
<lineContent>switch (fChild.getType()) {</lineContent>
</mutation>

and
<mutation unstable="false">
<sourceFile>SuppressWarningsCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.annotation.SuppressWarningsCheck</mutatedClass>
<mutatedMethod>visitToken</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.RemoveSwitchMutator_1</mutator>
<description>RemoveSwitch 1 mutation</description>
<lineContent>switch (fChild.getType()) {</lineContent>
</mutation>

@Kevin222004
Copy link
Collaborator Author

Kevin222004 commented Oct 22, 2022

Now, I will handle this all in one pr by just solving one at a time in my local

@romani
Copy link
Member

romani commented Oct 23, 2022

I highly recommend to send PR as soon as killed one mutation (or batch it by day of work). The smaller PR the quicker it is merged.

@rnveach
Copy link
Member

rnveach commented Jan 7, 2023

This will be resolved in #12591 which is waiting on pitest plugin changes, so I am closing this.

@rnveach rnveach closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants