Resolve Pitest suppression for ParenPad

[Kevin222004]

Related to #7797

kill mutation

checkstyle/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml

Lines 93 to 100 in fa68569

	<mutation unstable="false">
	<sourceFile>ParenPadCheck.java</sourceFile>
	<mutatedClass>com.puppycrawl.tools.checkstyle.checks.whitespace.ParenPadCheck</mutatedClass>
	<mutatedMethod>visitToken</mutatedMethod>
	<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.RemoveSwitchMutator_3</mutator>
	<description>RemoveSwitch 3 mutation</description>
	<lineContent>switch (ast.getType()) {</lineContent>
	</mutation>

[Kevin222004]

@rnveach We have currently this line of code which is mutated

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/ParenPadCheck.java

Line 257 in ad27aa0

case TokenTypes.QUESTION:

and the source code for this mutated code is just to remove it

[rnveach]

the source code for this mutated code is just to remove it

The mutation is not to remove it.
https://github.com/checkstyle/checkstyle/wiki/How-to-Generate-and-Analyze-Pitest-Reports#experimental-switch-mutator

We change each label to the default label
This mutation will change the 0th index case label and put it into the default label list.

Wiki saying remove it is not correct, but we change case and move it to default.

[Kevin222004]

@rnveach yes we don't have to remove the switch case according to wiki I have also done like that before. and know it is clear to me

when we are making the changes like that I am getting errors in three input file i am sharing one with you

checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/parenpad/InputParenPadLeftRightAndNoSpace1.java

Lines 122 to 126 in ad27aa0

	String foo() {
	return ( (Object // violation
	) bar( ( 1 > 2 ) ? // 3 violations
	( ( 3 < 4 )? false : true ) : // 4 violations
	( ( 1 == 1 ) ? false : true) ) ).toString(); // 5 violations

here the violation is missing in line 125 at 2 places
according to the current scenario checkstyle don't generate the violation for any case for QUESTION I just want to know it is expected a violation in such condition like line no 126 in same file according to its config comment msg

[rnveach]

If you make a change to mimic a mutation and our test fails, then either the mutation you applied isn't correct or there is more going on with pitest than the mutation alone (caching, etc...). Normally tests do not fail with the mutation applied.

Please provide me the step by step we request. Provide me the mutated branch pushed to the server and paste the URL here. Let me know if tests fail with the mutation applied.

[romani]

Please send PR with mutation to let us see all details.

Please try to remove all other "case" one by one.

[rnveach]

Fix was merged, complex understanding of pitest is at #12318 (comment) and simpler understanding at #12318 (comment)