Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Pitest suppression for EmptyForIteratorPadCheck #12261

Closed
Kevin222004 opened this issue Oct 7, 2022 · 5 comments
Closed

Resolve Pitest suppression for EmptyForIteratorPadCheck #12261

Kevin222004 opened this issue Oct 7, 2022 · 5 comments

Comments

@Kevin222004
Copy link
Collaborator

Kevin222004 commented Oct 7, 2022

Related to #7797

kill mutation

<description>replaced call to java/lang/String::trim with receiver</description>

and
<description>replaced call to java/lang/String::toUpperCase with receiver</description>

for EmptyForIteratorPadCheck

@romani
Copy link
Member

romani commented Oct 7, 2022

Can we fix all similar issues at one issue and multiple PR or one PR?

@nrmancuso
Copy link
Member

If we are only adding tests, I think it would be fine to resolve a few of these in the scope of one PR/issue.

@rnveach
Copy link
Member

rnveach commented Oct 7, 2022

My wording to him before this issue was:

Single mutation issues was just for getting started to ensure we can confirm communication and confirm understanding of pitest and how it functions. Since this check only has 2 mutations, please just create 1 more issue of a single mutation and afterwards I think we can do multiple. However, even with multiple it is best to keep separate PRs between adding tests and changing production code. Adding tests is easier to merge then changing production code which will require a closer review and regression reports.
Beware, if PRs start to get complex we will want them split more, so I would be careful on putting too much into a single PR. It is not that much more work to create separate branches and PRs.

this check was AbstractParenPadCheck at the time.

@Kevin222004
Copy link
Collaborator Author

I have updated the pr description

@rnveach
Copy link
Member

rnveach commented Oct 7, 2022

Fix was merged

@rnveach rnveach closed this as completed Oct 7, 2022
@rnveach rnveach added this to the 10.3.5 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants