Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up messages - mojibake, lone apostrophes and accidental apostrophes substitutes #10828

Closed
victorwss opened this issue Sep 27, 2021 · 2 comments
Closed

Fix up messages - mojibake, lone apostrophes and accidental apostrophes substitutes #10828

victorwss opened this issue Sep 27, 2021 · 2 comments
Labels
approved bug
Milestone
9.0.1

Comments

@victorwss
Copy link
Contributor

victorwss commented Sep 27, 2021 •
edited

Some message translations features:

  1. Mojibake.
  2. Lone apostrophes (they should be doubled due to escaping).
  3. Accidental apostrophes substitutes (` and ’ instead of ').

Disclaimer: Since #10811 and #10812 are too fat to be properly and fully peer-reviewed, I am resubmiting them in small baby-steps issues and commits.
@victorwss victorwss changed the title Fix up messages - mojibake, lone apostrophes and acidental apostrophes substitutes Fix up messages - mojibake, lone apostrophes and accidental apostrophes substitutes Sep 27, 2021
victorwss added a commit to victorwss/checkstyle that referenced this issue Sep 27, 2021
@victorwss
Issue: checkstyle#10828 - Fix up messages - mojibake, lone apostrophe…
f423026 
…s and accidental apostrophes substitutes
victorwss added a commit to victorwss/checkstyle that referenced this issue Sep 27, 2021
@victorwss
Issue checkstyle#10828: Fix up messages - mojibake, lone apostrophes …
9ae8e37 
…and accidental apostrophes substitutes
@victorwss victorwss mentioned this issue Sep 27, 2021
Merged
victorwss added a commit to victorwss/checkstyle that referenced this issue Sep 27, 2021
@victorwss
Issue checkstyle#10828: Fix up messages - mojibake, lone apostrophes …
e78384f 
…and accidental apostrophes substitutes
@romani romani added the bug label Oct 2, 2021
romani pushed a commit that referenced this issue Oct 2, 2021
@victorwss @romani
Issue #10828: Fix up messages - mojibake, lone apostrophes and accide…
0da7491 
…ntal apostrophes substitutes
@romani romani added this to the 9.1 milestone Oct 2, 2021
@romani
Copy link
Member

romani commented Nov 14, 2021 •
edited

@victorwss, is there something left to fix in this issue ?

If not, please close ticket.

@rnveach
Copy link
Member

rnveach commented Mar 24, 2022

@romani Should we close this as its been 5 months?

@romani romani closed this as completed Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved bug
Projects
None yet
Milestone
9.0.1
Development

No branches or pull requests
3 participants
@romani @victorwss @rnveach