Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation about external DTD loading #10791

Open
ddidier opened this issue Sep 9, 2021 · 2 comments
Open

Improve documentation about external DTD loading #10791

ddidier opened this issue Sep 9, 2021 · 2 comments
Labels

Comments

@ddidier
Copy link

ddidier commented Sep 9, 2021

A clarification has been made in #10788:

Checkstyle disallows the features by default in XMLs without that extra parameter:

* load-external-dtd
* external-general-entities
* external-parameter-entities

I couldn't find the second and third limitations in the documentation, and specifically not in https://checkstyle.sourceforge.io/config_system_properties.html#Enable_External_DTD_load, since it's related to checkstyle.enableExternalDtdLoad. The documentation must be more explicit about this.

@rnveach
Copy link
Member

rnveach commented Sep 10, 2021

Anyone is free to start a PR to improve documentation more.

@romani
Copy link
Member

romani commented Sep 11, 2021

@ddidier , website content is at https://github.com/checkstyle/checkstyle/blob/master/src/xdocs/config_system_properties.xml please propose wording you expect to be and set Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants