-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create README for Java grammar updates #10618
Comments
|
I think it should be a page in https://checkstyle.org/extending.html |
This is mostly for 3rd-party check/filters/etc., but grammar changes cant be 3rd party, it is a core functionality. We can start from wiki page (+link from main readme to it as must read for contributors who wants to change grammar) |
I should explain why I think that the guide should live in the main repo, and be written in markdown:
Instead of having a README in the grammar directory, another option is to create a |
@nrmancuso any updates here? I think it would be great to have an explanation of updating grammar and adding support for new tokens |
Hopefully I will get some time this summer :) Thanks for asking. |
From discussion at #10280 (comment) and elsewhere, with the new ANTLR4 grammar and visitor combination to build Checkstyle's AST, it may not be obvious to contributors how to update the grammar and create the AST. I propose that we write a guide, which will walk through the entire process form start to finish. Points of discussion here include:
The text was updated successfully, but these errors were encountered: