New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MatchXpath: should support comments #10107
Comments
I am on it ! |
AkMo3
added a commit
to AkMo3/checkstyle
that referenced
this issue
Jul 16, 2021
Just a note - this change can break backwards compatibility. |
AkMo3
added a commit
to AkMo3/checkstyle
that referenced
this issue
Jul 16, 2021
AkMo3
added a commit
to AkMo3/checkstyle
that referenced
this issue
Jul 17, 2021
romani
pushed a commit
that referenced
this issue
Jul 17, 2021
romani
changed the title
MatchXpath: doesn't support comments
MatchXpath: should support comments
Jul 17, 2021
fix is merged. |
AkMo3
added a commit
to AkMo3/checkstyle
that referenced
this issue
Jul 19, 2021
AkMo3
added a commit
to AkMo3/checkstyle
that referenced
this issue
Jul 20, 2021
strkkk
pushed a commit
that referenced
this issue
Jul 22, 2021
vinayak-gaikwad
pushed a commit
to vinayak-gaikwad/checkstyle
that referenced
this issue
Jul 22, 2021
AkMo3
added a commit
to AkMo3/checkstyle
that referenced
this issue
Aug 4, 2021
AkMo3
added a commit
to AkMo3/checkstyle
that referenced
this issue
Aug 4, 2021
romani
pushed a commit
that referenced
this issue
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to #7531
MatchXpath can't flag comments because it is not a comment aware check.
I don't believe it is at all related to PR #9832 since xpath relies on the tokens given to it and checks that aren't comment aware won't receive comments.
The text was updated successfully, but these errors were encountered: