How to suppress IllegalImport?

[delanym]

With checkstyle 10.9.2 I try to suppress the IllegalImport check some of the time, but unable to use this approach

  <module name="SuppressWarningsFilter"/>
  <module name="TreeWalker">
    <module name="SuppressWarningsHolder"/>
    <module name="IllegalImport">
      <property name="illegalClasses" value="java.util.Hashtable"/>
    </module>

I placed the suppression on the class in a number of ways:

@SuppressWarnings("illegalimport")
@SuppressWarnings("checkstyle:illegalimport")
@SuppressWarnings("checkstyle:IllegalImport")
@SuppressWarnings("check:illegalimport")
@SuppressWarnings("com.puppycrawl.tools.checkstyle.checks.import.IllegalImport")
@SuppressWarnings("com.puppycrawl.tools.checkstyle.checks.import.IllegalImportCheck")

but I always get (imports) IllegalImport: Illegal import - java.util.Hashtable.

[romani]

Try to put annotation on import.
Consider another filters to suppress violations.

https://checkstyle.org/config_filters.html

[delanym]

@nrmancuso modernizer considers java.util.HashTable a legacy api.
You can suppress with annotations (https://github.com/gaul/modernizer-maven-plugin#ignoring-elements) but I didn't do that.
I added this to my project

      <plugin>
        <groupId>org.gaul</groupId>
        <artifactId>modernizer-maven-plugin</artifactId>
        <executions>
          <execution>
            <id>modernizer</id>
            <configuration>
              <ignoreClassNamePatterns>
                <ignoreClassNamePattern>blah.blah.blah.blah.blah.blah.Classlah2</ignoreClassNamePattern>
                <ignoreClassNamePattern>blah.blah.blah.blah.blah.blah.Classlah3</ignoreClassNamePattern>
              </ignoreClassNamePatterns>
            </configuration>
          </execution>
        </executions>
      </plugin>

This way the suppression is in the pom of module 43 of 500, rather than in checkstyle.xml which sits in a global build-tools artefact from another repo.

If the checkstyle.xml could be made more dynamic I might use it, but as it stands there's already so much in that file and no nice way to organize it.

[romani]

@delanym, please share exact config that worked for you

[delanym]

The parent pom has this

      <pluginManagement>
        <plugin>
          <groupId>org.gaul</groupId>
          <artifactId>modernizer-maven-plugin</artifactId>
          <version>2.6.0</version>
          <executions>
            <execution>
              <id>modernizer</id>
              <goals>
                <goal>modernizer</goal>
              </goals>
              <phase>verify</phase>
              <configuration>
                <javaVersion>19</javaVersion>
                <failOnViolations>true</failOnViolations>
              </configuration>
            </execution>
          </executions>
        </plugin>
      </pluginManagement>

[romani]

Sorry, I meant config of filter in checkstyle config

[delanym]

I don't have the config anymore. I went the "by non-query" route.

<module name="SuppressionXpathSingleFilter">
  <property name="files" value="FileOne.java"/>
  <property name="checks" value="IllegalImport"/>
</module>

[nrmancuso]

some of the time

@delanym if there is some pattern/reason for why you need to suppress this sometimes, maybe we can help to create a filter/suppression

[delanym]

JNDI requires use of HashTable so we have to allow it https://docs.oracle.com/javase/jndi/tutorial/basics/prepare/initial.html but I don't want it used anywhere else