From edd2b094f70f908994013f5f45de3c2ecb8b3e23 Mon Sep 17 00:00:00 2001
From: Shubh Srivastava <shubh22.srivastava@gmail.com>
Date: Wed, 23 Nov 2022 09:31:10 +0530
Subject: [PATCH] Issue #12326: Resolve Pitest suppression for
 AccessModifierOption

---
 .../pitest-naming-suppressions.xml            |  9 --------
 .../checks/naming/ParameterNameCheckTest.java | 11 +++++++++
 ...ameWhitespaceInAccessModifierProperty.java | 23 +++++++++++++++++++
 3 files changed, 34 insertions(+), 9 deletions(-)
 create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/parametername/InputParameterNameWhitespaceInAccessModifierProperty.java

diff --git a/.ci/pitest-suppressions/pitest-naming-suppressions.xml b/.ci/pitest-suppressions/pitest-naming-suppressions.xml
index 31c0d0a6a6e..c07806dfd9b 100644
--- a/.ci/pitest-suppressions/pitest-naming-suppressions.xml
+++ b/.ci/pitest-suppressions/pitest-naming-suppressions.xml
@@ -9,15 +9,6 @@
     <lineContent>curNode = curNode.getNextSibling();</lineContent>
   </mutation>
 
-  <mutation unstable="false">
-    <sourceFile>AccessModifierOption.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.checks.naming.AccessModifierOption</mutatedClass>
-    <mutatedMethod>getInstance</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
-    <description>replaced call to java/lang/String::trim with receiver</description>
-    <lineContent>return valueOf(AccessModifierOption.class, modifierName.trim().toUpperCase(Locale.ENGLISH));</lineContent>
-  </mutation>
-
   <mutation unstable="false">
     <sourceFile>ParameterNameCheck.java</sourceFile>
     <mutatedClass>com.puppycrawl.tools.checkstyle.checks.naming.ParameterNameCheck</mutatedClass>
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java
index 6fe90652948..bcc678dc2db 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java
@@ -68,6 +68,17 @@ public void testSpecified()
                 getPath("InputParameterNameOne.java"), expected);
     }
 
+    @Test
+    public void testWhitespaceInAccessModifierProperty() throws Exception {
+        final String pattern = "^h$";
+        final String[] expected = {
+            "14:69: " + getCheckMessage(MSG_INVALID_PATTERN, "parameter1", pattern),
+            "18:31: " + getCheckMessage(MSG_INVALID_PATTERN, "parameter2", pattern),
+        };
+        verifyWithInlineConfigParser(
+                getPath("InputParameterNameWhitespaceInAccessModifierProperty.java"), expected);
+    }
+
     @Test
     public void testDefault()
             throws Exception {
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/parametername/InputParameterNameWhitespaceInAccessModifierProperty.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/parametername/InputParameterNameWhitespaceInAccessModifierProperty.java
new file mode 100644
index 00000000000..d9b0d29adb6
--- /dev/null
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/parametername/InputParameterNameWhitespaceInAccessModifierProperty.java
@@ -0,0 +1,23 @@
+/*
+ParameterName
+format = ^h$
+ignoreOverridden = (default)false
+accessModifiers = \tpublic
+
+
+*/
+
+package com.puppycrawl.tools.checkstyle.checks.naming.parametername;
+
+public class InputParameterNameWhitespaceInAccessModifierProperty {
+
+    public InputParameterNameWhitespaceInAccessModifierProperty(int parameter1) {} // violation
+
+    public void v1(int h) { // ok
+        new Object () {
+            public void i(int parameter2) {} // violation
+        };
+    }
+
+    void method2(int V3) {}
+}