From e63589759de1d5b5461b60b59e2db6a0e9143fe7 Mon Sep 17 00:00:00 2001 From: Vyom-Yadav Date: Fri, 22 Jul 2022 16:54:45 +0530 Subject: [PATCH] Issue #11720: Kill surviving mutation in VariableDeclarationUsageDistanceCheck in calculateDistanceInSingleScope --- .ci/pitest-suppressions/pitest-coding-1-suppressions.xml | 9 --------- .../coding/VariableDeclarationUsageDistanceCheck.java | 3 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/.ci/pitest-suppressions/pitest-coding-1-suppressions.xml b/.ci/pitest-suppressions/pitest-coding-1-suppressions.xml index ae3bea5dff7..ba2f9691678 100644 --- a/.ci/pitest-suppressions/pitest-coding-1-suppressions.xml +++ b/.ci/pitest-suppressions/pitest-coding-1-suppressions.xml @@ -1,14 +1,5 @@ - - VariableDeclarationUsageDistanceCheck.java - com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck - calculateDistanceInSingleScope - org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF - removed conditional - replaced equality check with true - && currentAst.getType() != TokenTypes.RCURLY) { - - VariableDeclarationUsageDistanceCheck.java com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java index 4b8c2d4e7d7..82c2500748b 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java @@ -530,8 +530,7 @@ private static Entry calculateDistanceInSingleScope( DetailAST currentAst = semicolonAst; DetailAST variableUsageAst = null; - while (!firstUsageFound && currentAst != null - && currentAst.getType() != TokenTypes.RCURLY) { + while (!firstUsageFound && currentAst != null) { if (currentAst.getFirstChild() != null) { if (isChild(currentAst, variableIdentAst)) { dist = getDistToVariableUsageInChildNode(currentAst, variableIdentAst, dist);