diff --git a/config/import-control-test.xml b/config/import-control-test.xml
index 0b46547b5905..dc0f2f27d3b2 100644
--- a/config/import-control-test.xml
+++ b/config/import-control-test.xml
@@ -16,4 +16,12 @@
+
+
+
+
+
+
+
+
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationLocationCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationLocationCheckTest.java
index f47aa3231f02..1c6ad608e437 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationLocationCheckTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationLocationCheckTest.java
@@ -21,9 +21,9 @@
import static com.puppycrawl.tools.checkstyle.checks.annotation.AnnotationLocationCheck.MSG_KEY_ANNOTATION_LOCATION;
import static com.puppycrawl.tools.checkstyle.checks.annotation.AnnotationLocationCheck.MSG_KEY_ANNOTATION_LOCATION_ALONE;
-import static org.junit.Assert.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
@@ -40,9 +40,8 @@ protected String getPackageLocation() {
@Test
public void testGetRequiredTokens() {
final AnnotationLocationCheck checkObj = new AnnotationLocationCheck();
- assertArrayEquals(
- "AnnotationLocationCheck#getRequiredTokens should return empty array by default",
- CommonUtil.EMPTY_INT_ARRAY, checkObj.getRequiredTokens());
+ assertArrayEquals(CommonUtil.EMPTY_INT_ARRAY, checkObj.getRequiredTokens(),
+ "AnnotationLocationCheck#getRequiredTokens should return empty array by default");
}
@Test
@@ -136,7 +135,7 @@ public void testGetAcceptableTokens() {
TokenTypes.ANNOTATION_DEF,
TokenTypes.ANNOTATION_FIELD_DEF,
};
- assertArrayEquals("Default acceptable tokens are invalid", expected, actual);
+ assertArrayEquals(expected, actual, "Default acceptable tokens are invalid");
}
@Test
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationOnSameLineCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationOnSameLineCheckTest.java
index aedfc5f80b40..2872803c77a3 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationOnSameLineCheckTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationOnSameLineCheckTest.java
@@ -20,9 +20,9 @@
package com.puppycrawl.tools.checkstyle.checks.annotation;
import static com.puppycrawl.tools.checkstyle.checks.annotation.AnnotationOnSameLineCheck.MSG_KEY_ANNOTATION_ON_SAME_LINE;
-import static org.junit.Assert.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
@@ -39,9 +39,8 @@ protected String getPackageLocation() {
@Test
public void testGetRequiredTokens() {
final AnnotationOnSameLineCheck check = new AnnotationOnSameLineCheck();
- assertArrayEquals(
- "AnnotationOnSameLineCheck#getRequiredTokens should return empty array by default",
- CommonUtil.EMPTY_INT_ARRAY, check.getRequiredTokens());
+ assertArrayEquals(CommonUtil.EMPTY_INT_ARRAY, check.getRequiredTokens(),
+ "AnnotationOnSameLineCheck#getRequiredTokens should return empty array by default");
}
@Test
@@ -65,7 +64,7 @@ public void testGetAcceptableTokens() {
TokenTypes.DOT,
TokenTypes.ANNOTATION_FIELD_DEF,
};
- assertArrayEquals("Default acceptable tokens are invalid", expected, actual);
+ assertArrayEquals(expected, actual, "Default acceptable tokens are invalid");
}
@Test
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationUseStyleCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationUseStyleCheckTest.java
index 144acffe98b9..f8430ac6cf94 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationUseStyleCheckTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationUseStyleCheckTest.java
@@ -24,11 +24,12 @@
import static com.puppycrawl.tools.checkstyle.checks.annotation.AnnotationUseStyleCheck.MSG_KEY_ANNOTATION_PARENS_PRESENT;
import static com.puppycrawl.tools.checkstyle.checks.annotation.AnnotationUseStyleCheck.MSG_KEY_ANNOTATION_TRAILING_COMMA_MISSING;
import static com.puppycrawl.tools.checkstyle.checks.annotation.AnnotationUseStyleCheck.MSG_KEY_ANNOTATION_TRAILING_COMMA_PRESENT;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
@@ -50,8 +51,8 @@ protected String getPackageLocation() {
public void testElementStyleValueOf() {
final AnnotationUseStyleCheck.ElementStyle option =
AnnotationUseStyleCheck.ElementStyle.valueOf("COMPACT");
- assertEquals("Invalid valueOf result",
- AnnotationUseStyleCheck.ElementStyle.COMPACT, option);
+ assertEquals(AnnotationUseStyleCheck.ElementStyle.COMPACT, option,
+ "Invalid valueOf result");
}
/* Additional test for jacoco, since valueOf()
@@ -62,8 +63,8 @@ public void testElementStyleValueOf() {
public void testTrailingArrayCommaValueOf() {
final AnnotationUseStyleCheck.TrailingArrayComma option =
AnnotationUseStyleCheck.TrailingArrayComma.valueOf("ALWAYS");
- assertEquals("Invalid valueOf result",
- AnnotationUseStyleCheck.TrailingArrayComma.ALWAYS, option);
+ assertEquals(AnnotationUseStyleCheck.TrailingArrayComma.ALWAYS, option,
+ "Invalid valueOf result");
}
/* Additional test for jacoco, since valueOf()
@@ -74,8 +75,8 @@ public void testTrailingArrayCommaValueOf() {
public void testClosingParensValueOf() {
final AnnotationUseStyleCheck.ClosingParens option =
AnnotationUseStyleCheck.ClosingParens.valueOf("ALWAYS");
- assertEquals("Invalid valueOf result",
- AnnotationUseStyleCheck.ClosingParens.ALWAYS, option);
+ assertEquals(AnnotationUseStyleCheck.ClosingParens.ALWAYS, option,
+ "Invalid valueOf result");
}
@Test
@@ -337,7 +338,7 @@ public void testGetAcceptableTokens() {
final AnnotationUseStyleCheck constantNameCheckObj = new AnnotationUseStyleCheck();
final int[] actual = constantNameCheckObj.getAcceptableTokens();
final int[] expected = {TokenTypes.ANNOTATION };
- Assert.assertArrayEquals("Invalid acceptable tokens", expected, actual);
+ assertArrayEquals(expected, actual, "Invalid acceptable tokens");
}
@Test
@@ -345,13 +346,13 @@ public void testGetOption() {
final AnnotationUseStyleCheck check = new AnnotationUseStyleCheck();
try {
check.setElementStyle("SHOULD_PRODUCE_ERROR");
- Assert.fail("ConversionException is expected");
+ fail("ConversionException is expected");
}
catch (IllegalArgumentException ex) {
final String messageStart = "unable to parse";
- assertTrue("Invalid exception message, should start with: " + messageStart,
- ex.getMessage().startsWith(messageStart));
+ assertTrue(ex.getMessage().startsWith(messageStart),
+ "Invalid exception message, should start with: " + messageStart);
}
}
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheckTest.java
index cbc745b3b15a..8804b160146f 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheckTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheckTest.java
@@ -21,9 +21,9 @@
import static com.puppycrawl.tools.checkstyle.checks.annotation.MissingDeprecatedCheck.MSG_KEY_ANNOTATION_MISSING_DEPRECATED;
import static com.puppycrawl.tools.checkstyle.checks.annotation.MissingDeprecatedCheck.MSG_KEY_JAVADOC_DUPLICATE_TAG;
-import static org.junit.Assert.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
@@ -45,8 +45,8 @@ public void testGetDefaultJavadocTokens() {
JavadocTokenTypes.JAVADOC,
};
- assertArrayEquals("Default javadoc tokens are invalid",
- expected, missingDeprecatedCheck.getDefaultJavadocTokens());
+ assertArrayEquals(expected, missingDeprecatedCheck.getDefaultJavadocTokens(),
+ "Default javadoc tokens are invalid");
}
@Test
@@ -55,8 +55,8 @@ public void testGetRequiredJavadocTokens() {
final int[] expected = {
JavadocTokenTypes.JAVADOC,
};
- assertArrayEquals("Default required javadoc tokens are invalid",
- expected, checkObj.getRequiredJavadocTokens());
+ assertArrayEquals(expected, checkObj.getRequiredJavadocTokens(),
+ "Default required javadoc tokens are invalid");
}
/**
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheckTest.java
index e24621fb6495..63cfe3e786cd 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheckTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheckTest.java
@@ -21,10 +21,10 @@
import static com.puppycrawl.tools.checkstyle.checks.annotation.MissingOverrideCheck.MSG_KEY_ANNOTATION_MISSING_OVERRIDE;
import static com.puppycrawl.tools.checkstyle.checks.annotation.MissingOverrideCheck.MSG_KEY_TAG_NOT_VALID_ON;
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
@@ -238,8 +238,8 @@ public void testGetAcceptableTokens() {
final int[] expectedTokens = {TokenTypes.METHOD_DEF };
final MissingOverrideCheck check = new MissingOverrideCheck();
final int[] actual = check.getAcceptableTokens();
- assertEquals("Invalid acceptable token size", 1, actual.length);
- Assert.assertArrayEquals("Default required tokens are invalid", expectedTokens, actual);
+ assertEquals(1, actual.length, "Invalid acceptable token size");
+ assertArrayEquals(expectedTokens, actual, "Default required tokens are invalid");
}
}
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/PackageAnnotationCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/PackageAnnotationCheckTest.java
index a5813bdda216..992ca02d4fe3 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/PackageAnnotationCheckTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/PackageAnnotationCheckTest.java
@@ -20,9 +20,9 @@
package com.puppycrawl.tools.checkstyle.checks.annotation;
import static com.puppycrawl.tools.checkstyle.checks.annotation.PackageAnnotationCheck.MSG_KEY;
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
@@ -53,7 +53,7 @@ public void testGetAcceptableTokens() {
final PackageAnnotationCheck constantNameCheckObj = new PackageAnnotationCheck();
final int[] actual = constantNameCheckObj.getAcceptableTokens();
final int[] expected = {TokenTypes.PACKAGE_DEF };
- Assert.assertArrayEquals("Invalid acceptable tokens", expected, actual);
+ assertArrayEquals(expected, actual, "Invalid acceptable tokens");
}
@Test
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheckTest.java
index 6126af1829bf..b0150ac6e21a 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheckTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheckTest.java
@@ -21,7 +21,7 @@
import static com.puppycrawl.tools.checkstyle.checks.annotation.SuppressWarningsCheck.MSG_KEY_SUPPRESSED_WARNING_NOT_ALLOWED;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;