From b51b4af16093835732716d8237e45658b4afea04 Mon Sep 17 00:00:00 2001 From: Kevin222004 Date: Tue, 11 Oct 2022 03:17:39 +0530 Subject: [PATCH] Issue #12275: Resolve Pitest suppression for EmptyForInitializerPad-2 --- .../pitest-whitespace-suppressions.xml | 9 --------- .../checks/whitespace/EmptyForInitializerPadCheck.java | 8 +++----- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml b/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml index 963bf9202e3..31965f6faef 100644 --- a/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml +++ b/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml @@ -1,14 +1,5 @@ - - EmptyForInitializerPadCheck.java - com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyForInitializerPadCheck - visitToken - org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator - replaced call to com/puppycrawl/tools/checkstyle/api/DetailAST::getNextSibling with receiver - final DetailAST semi = ast.getNextSibling(); - - EmptyLineSeparatorCheck.java com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForInitializerPadCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForInitializerPadCheck.java index 20e64d5797a..6fc77b0e2f7 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForInitializerPadCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForInitializerPadCheck.java @@ -148,11 +148,9 @@ public int[] getRequiredTokens() { @Override public void visitToken(DetailAST ast) { if (!ast.hasChildren()) { - // empty for initializer. test pad before semi. - final DetailAST semi = ast.getNextSibling(); - final int semiLineIdx = semi.getLineNo() - 1; - final int[] line = getLineCodePoints(semiLineIdx); - final int before = semi.getColumnNo() - 1; + final int lineIdx = ast.getLineNo() - 1; + final int[] line = getLineCodePoints(lineIdx); + final int before = ast.getColumnNo() - 1; // don't check if semi at beginning of line if (!CodePointUtil.hasWhitespaceBefore(before, line)) { if (option == PadOption.NOSPACE