From 7c7958a6004f3a0bd4c9444027ecdffc8ae9353f Mon Sep 17 00:00:00 2001 From: Aryaniiit002 Date: Mon, 8 Feb 2021 17:21:21 +0530 Subject: [PATCH] Issue #7878: Resolve Pitest Issues ImportOrderCheck (7) --- .ci/pitest.sh | 1 - .../tools/checkstyle/checks/imports/ImportOrderCheck.java | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.ci/pitest.sh b/.ci/pitest.sh index fac8d1ded10..ce654611bff 100755 --- a/.ci/pitest.sh +++ b/.ci/pitest.sh @@ -65,7 +65,6 @@ pitest-imports) declare -a ignoredItems=( "ImportControlLoader.java.html:
        else if (ALLOW_ELEMENT_NAME.equals(qName) || "disallow".equals(qName)) {
" "ImportOrderCheck.java.html:
        return !beforeFirstImport && line - lastImportLine > 1;
" - "ImportOrderCheck.java.html:
            staticImportSeparator = isStatic && separated;
" "PkgImportControl.java.html:
        if (alreadyRegex) {
" "PkgImportControl.java.html:
        if (regex || parent.regex) {
" "PkgImportControl.java.html:
        if (regex) {
" diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java index 8917da12dba..791e2ec097e 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java @@ -847,7 +847,7 @@ private boolean needSeparator(boolean isStatic) { staticImportSeparator = isStatic && separatedStaticGroups; } else { - staticImportSeparator = isStatic && separated; + staticImportSeparator = separated; } final boolean separatorBetween = isStatic != lastImportStatic && (separated || separatedStaticGroups);