From 5e61fbb893ca0ad68310553b81cf8c4a9bf363f7 Mon Sep 17 00:00:00 2001 From: Vyom-Yadav Date: Sat, 23 Jul 2022 14:28:18 +0530 Subject: [PATCH] Issue #11720: Kill surviving mutation in VariableDeclarationUsageDistanceCheck in getFirstNodeInsideForWhileDoWhileBlocks --- .ci/pitest-suppressions/pitest-coding-1-suppressions.xml | 9 --------- .../coding/VariableDeclarationUsageDistanceCheck.java | 5 +---- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/.ci/pitest-suppressions/pitest-coding-1-suppressions.xml b/.ci/pitest-suppressions/pitest-coding-1-suppressions.xml index 03c4e89177d..1b77ac98e67 100644 --- a/.ci/pitest-suppressions/pitest-coding-1-suppressions.xml +++ b/.ci/pitest-suppressions/pitest-coding-1-suppressions.xml @@ -9,15 +9,6 @@ if (!firstUsageFound) { - - VariableDeclarationUsageDistanceCheck.java - com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck - getFirstNodeInsideForWhileDoWhileBlocks - org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE - removed conditional - replaced equality check with false - if (currentNodeType == TokenTypes.SLIST) { - - VariableDeclarationUsageDistanceCheck.java com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java index d1b5a08ffb5..322c2e10cd7 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java @@ -740,10 +740,7 @@ private static DetailAST getFirstNodeInsideForWhileDoWhileBlocks( final int currentNodeType = currentNode.getType(); - if (currentNodeType == TokenTypes.SLIST) { - firstNodeInsideBlock = currentNode.getFirstChild(); - } - else if (currentNodeType != TokenTypes.EXPR) { + if (currentNodeType != TokenTypes.EXPR) { firstNodeInsideBlock = currentNode; } }