From 34d8e1554e3e5251ae27bc4c0d0ac471f95c1dab Mon Sep 17 00:00:00 2001 From: Kevin222004 Date: Fri, 7 Oct 2022 23:44:49 +0530 Subject: [PATCH] Issue #12264: Resolve Pitest suppression for MethodParamPadCheck --- .../pitest-whitespace-suppressions.xml | 9 ------ .../whitespace/MethodParamPadCheckTest.java | 9 ++++++ .../InputMethodParamPadSetOptionTrim.java | 32 +++++++++++++++++++ 3 files changed, 41 insertions(+), 9 deletions(-) create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/methodparampad/InputMethodParamPadSetOptionTrim.java diff --git a/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml b/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml index 6f8eca5e5d0..4938e823a79 100644 --- a/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml +++ b/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml @@ -99,15 +99,6 @@ depth = 0; - - MethodParamPadCheck.java - com.puppycrawl.tools.checkstyle.checks.whitespace.MethodParamPadCheck - setOption - org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator - replaced call to java/lang/String::trim with receiver - option = PadOption.valueOf(optionStr.trim().toUpperCase(Locale.ENGLISH)); - - ParenPadCheck.java com.puppycrawl.tools.checkstyle.checks.whitespace.ParenPadCheck diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/MethodParamPadCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/MethodParamPadCheckTest.java index dfa4dee9cab..215ad6116d3 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/MethodParamPadCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/MethodParamPadCheckTest.java @@ -200,4 +200,13 @@ public void testInvalidOption() throws Exception { } } + @Test + public void testTrimOptionProperty() throws Exception { + final String[] expected = { + "15:24: " + getCheckMessage(MSG_WS_NOT_PRECEDED, "("), + "26:27: " + getCheckMessage(MSG_WS_NOT_PRECEDED, "("), + }; + verifyWithInlineConfigParser( + getPath("InputMethodParamPadSetOptionTrim.java"), expected); + } } diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/methodparampad/InputMethodParamPadSetOptionTrim.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/methodparampad/InputMethodParamPadSetOptionTrim.java new file mode 100644 index 00000000000..77f04273c02 --- /dev/null +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/methodparampad/InputMethodParamPadSetOptionTrim.java @@ -0,0 +1,32 @@ +/* +MethodParamPad +allowLineBreaks = (default)false +option = \tspace +tokens = (default)CTOR_DEF, LITERAL_NEW, METHOD_CALL, METHOD_DEF, SUPER_CTOR_CALL, \ + ENUM_CONSTANT_DEF, RECORD_DEF + + +*/ + +package com.puppycrawl.tools.checkstyle.checks.whitespace.methodparampad; + +public class InputMethodParamPadSetOptionTrim { + + public void method1() { // violation ''(' is not preceded with whitespace' + int a = 1, b = 2; + if (a > b) { + System.out.println (a); + } + } + + public int method2 () { // ok + return 1; + } + + public Boolean method3() { // violation ''(' is not preceded with whitespace' + if (4 < 5) { + return true; + } + return false; + } +}