Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot merge (missing required reviews) #784

Closed
styfle opened this issue Feb 1, 2022 · 4 comments
Closed

cannot merge (missing required reviews) #784

styfle opened this issue Feb 1, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@styfle
Copy link

styfle commented Feb 1, 2022

I've had few PRs that didn't merge even though CI completed required checks and I approved the PR.

Here's the most recent one I had to manually approve vercel/next.js#33825

Kodiak said "cannot merge (missing required reviews)"

@styfle styfle added the bug Something isn't working label Feb 1, 2022
@chdsbd
Copy link
Owner

chdsbd commented Feb 1, 2022

Thanks for the report! I'll take a look and get back to you

@chdsbd
Copy link
Owner

chdsbd commented Feb 1, 2022

At 6:17pm ET, Kodiak set a status message on that PR of "🛑 cannot merge (missing required reviews)", but looking at the PR, the PR was approved as of 6:15pm ET.

My guess is there was some race condition or replication lag between GitHub web hooks for the review and the review status being available in the API

I'll keep looking into this.

@styfle
Copy link
Author

styfle commented Feb 1, 2022

I think this is a false alarm.

I remember now that I had to click the force merge checkbox as an admin.

So that must mean the way codeowners is configured is requiring more than one approval.

Sorry about the confusion 😅

@styfle styfle closed this as completed Feb 1, 2022
@chdsbd
Copy link
Owner

chdsbd commented Feb 1, 2022

Great news! Thanks for the update @styfle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants