Allow newer versions of peerDependencies
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeLenaleee
reviewed
Aug 10, 2022
Comment on lines
+47
to
+49
| "jasmine": ">=3.0.0", | ||
| "karma": ">=6.0.0", | ||
| "karma-jasmine": ">=4.0.0" |
There was a problem hiding this comment.
Shouldn't we keep the minimum versions like they are now?
There was a problem hiding this comment.
The prior minimum versions aren't actually the minimal accepted versions but were just copied over from what was previously in dependencies: #18. So lower versions should work and there's no reason to disallow them. That being said, no one has complained, and I have no objection to leaving the minimum version at a higher value if you'd still like to do that
There was a problem hiding this comment.
dont know if we use any things that got addeded or fixed between what we used before and the lower version now, if thats not the case this is fine
kurkle
approved these changes
Sep 16, 2022
etimberg
approved these changes
Sep 16, 2022
LeeLenaleee
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're being prevented from updating the Chart.js dependencies due to the way the
peerDependenciesare specified here