convert karma+jasmine to peer deps #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kurkle do you have any idea why the test workflow isn't running? anything I can do to help fix it? |
|
@snoozbuster first time contributors need to be approved for runners. I just did. I'm going to test the change with couple of repositories before approving, hopefully tomorrow. |
kurkle
approved these changes
Jan 21, 2022
etimberg
approved these changes
Jan 21, 2022
|
hey @kurkle - is this ready to merge? anything left I can help with? |
|
Yeah sure. Was waiting if others have anything to say on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17.
I considered also making tweaks to
addMatchersandspecsFromFixturesto allow the consumers to optionally pass in a reference to thejasmine/karmaglobals, but I don't have the bandwidth to go update the other repos to consume such a change, so I decided not to for now.