Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo links in the readme seems to be broken #104

Open
bboydflo opened this issue Oct 6, 2021 · 4 comments
Open

demo links in the readme seems to be broken #104

bboydflo opened this issue Oct 6, 2021 · 4 comments

Comments

@bboydflo
Copy link

bboydflo commented Oct 6, 2021

Hi, I just wanted to give a heads up that at least 2 links in the readme of this plugin are broken. I found them in the Related plugins section

❌ chartjs-plugin-crosshair (demo)
❌ chartjs-plugin-streaming (demo)

@benmccann
Copy link
Collaborator

I fixed one and asked about the other AbelHeinsbroek/chartjs-plugin-crosshair#85

@abhinavsood
Copy link

@benmccann chartjs-plugin-crosshair does not seem to be active anymore. It's been broken for a while - not just the link, but the plugin does not work with chartjs v3 and fixes don't seem to be coming.

@benmccann
Copy link
Collaborator

Looks like there's a v3 branch, but they've been slow to update things: AbelHeinsbroek/chartjs-plugin-crosshair#65 (comment). I'll ask for an update there

@abhinavsood
Copy link

Looks like there's a v3 branch, but they've been slow to update things: AbelHeinsbroek/chartjs-plugin-crosshair#65 (comment). I'll ask for an update there

Thank you, @benmccann ! Are there any planned updates for this plugin? I'd love to be able to use the latest version of ChartJS (#128 ) and candlestick candles (high/low) disappear if the dataset is hidden and shown again (#103 , #117 )

I am not a JS developer, but if you could point me to the relevant bits of code, I could take a stab at fixing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants