Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart.js dependency does not specify a license #6348

Closed
donmccurdy opened this issue Jun 20, 2019 · 5 comments
Closed

Chart.js dependency does not specify a license #6348

donmccurdy opened this issue Jun 20, 2019 · 5 comments

Comments

@donmccurdy
Copy link

donmccurdy commented Jun 20, 2019

The js-green-licenses license checker reports an issue for any project that depends on Chart.js —

Checking package.json...

(no license): color-convert@0.5.3
  <my project>@0.0.0 -> chart.js@2.8.0 -> chartjs-color@2.3.0 -> color-convert@0.5.3

1 non-green licenses found.

The most recent version of chartjs-color depends on an old version of color-convert, which has no license specified. More recent versions of color-convert do include an MIT license. Could this dependency be upgraded in the chartjs-color module?

@donmccurdy donmccurdy changed the title Chart.js dependency has no license Chart.js dependency does not specify a license Jun 20, 2019
@donmccurdy
Copy link
Author

Looks like the license is there in the repository, but not specified in package.json. All the same, it would be helpful if this could be updated.

@donmccurdy
Copy link
Author

Related: chartjs/chartjs-color#3

@benmccann
Copy link
Contributor

@donmccurdy I sent chartjs/chartjs-color#6 awhile ago to upgrade that dependency. Does it fix it for you?

@etimberg @nagix would one of you be able to merge chartjs/chartjs-color#6?

@donmccurdy
Copy link
Author

Any version of color-convert >=0.7.0 has the license specified, so your PR does solve that – thanks! I don't know much about the rest of the changes involved there, though.

@benmccann
Copy link
Contributor

Fix here: #6663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants