Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unclipped scales #11402

Closed
joshkel opened this issue Jul 12, 2023 · 4 comments · Fixed by #11404
Closed

Allow unclipped scales #11402

joshkel opened this issue Jul 12, 2023 · 4 comments · Fixed by #11404

Comments

@joshkel
Copy link
Contributor

joshkel commented Jul 12, 2023

Feature Proposal

Starting in #10691, a dataset is automatically clipped to its scales' range. We have some custom scales that control an area for plotting but aren't intended to override the chart's normal clipping area.

Would it be worth adding an option (either via scale options or via a new scale API) to allow scales to control whether or not they're considered for clipping? If not, we can work around it locally.

Possible Implementation

No response

@stockiNail
Copy link
Contributor

It could make sense for me to add an option. My 2 cents.

@etimberg
Copy link
Member

We already have a clip option to control this elsewhere so i am onboard with adding an option to the scale or dataset for this (not sure where the best place is)

@stockiNail
Copy link
Contributor

@joshkel @etimberg I think it could be better to have new option at scale level.I have submitted a PR #11404 adding clip option to scales configuration.

@sbourouis
Copy link

sbourouis commented Apr 10, 2024

I'm not sure if it's a regression but clip doesn't seem to be working on the scale level anymore.
When I set clip: false on the x and y scales level
image
When I set clip: false in the options (not on scales)
image
When I set clip: false in the options and clip: true in the scales x options
image

I want to set clip: false in the options scales.x only, is there any way? Am I missing something?

I've opened a bug ticket there #11741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants