Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hotfix chart.js/auto for commonjs #10992

Merged
merged 2 commits into from Dec 16, 2022
Merged

fix: hotfix chart.js/auto for commonjs #10992

merged 2 commits into from Dec 16, 2022

Conversation

dangreen
Copy link
Collaborator

Sorry for my fault

fixes that:

const exports = require('../dist/chart.cjs');
      ^

Uncaught SyntaxError: Identifier 'exports' has already been declared

kurkle
kurkle reviewed Dec 16, 2022
View reviewed changes
auto/auto.cjs Show resolved Hide resolved
@dangreen dangreen marked this pull request as ready for review December 16, 2022 09:28
kurkle
kurkle previously approved these changes Dec 16, 2022
View reviewed changes
@kurkle kurkle added this to the Version 4.1.1 milestone Dec 16, 2022
@etimberg etimberg merged commit bc84a98 into chartjs:master Dec 16, 2022
@dangreen dangreen deleted the fix-commonjs-auto branch December 16, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 4.1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dangreen @etimberg @kurkle @LeeLenaleee