Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: restore commonjs bundle #10984

Merged
merged 1 commit into from Dec 15, 2022
Merged

feat: restore commonjs bundle #10984

merged 1 commit into from Dec 15, 2022

Conversation

dangreen
Copy link
Collaborator

No description provided.

@dangreen dangreen marked this pull request as ready for review December 15, 2022 17:37
@dangreen dangreen mentioned this pull request Dec 15, 2022
Closed
kurkle
kurkle reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another integration test for a non-module use case? Node behaves differently ofc.
I'd actually keep the replaced one as well, it should also work.

Edit: by non-module I refer to package.json module field (or the absense of it)

kurkle
kurkle approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope from this PR, but would be nice to have more integration tests with different use cases. Also could run these with different node versions.14..18 for example.

etimberg
etimberg approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go for 4.1.0 too?

@kurkle kurkle added this to the Version 4.1 milestone Dec 15, 2022
@kurkle kurkle merged commit 35fd620 into chartjs:master Dec 15, 2022
@dangreen dangreen deleted the feat-commonjs branch December 16, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbrunel simonbrunel simonbrunel approved these changes

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

@LeeLenaleee LeeLenaleee Awaiting requested review from LeeLenaleee

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dangreen @simonbrunel @etimberg @kurkle