From 1777f959e5f4a80091dd89e798b239b7ba788eb5 Mon Sep 17 00:00:00 2001 From: Arun Philip Date: Mon, 11 Mar 2024 04:57:07 -0400 Subject: [PATCH] platform.isAttached should return false if canvas is false-y (#11707) * platform.isAttached should return false if canvas is false-y * change styling to conform to codeclimate linter --- src/helpers/helpers.dom.ts | 2 +- src/platform/platform.dom.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/helpers/helpers.dom.ts b/src/helpers/helpers.dom.ts index c83712983ac..e06fefe94a6 100644 --- a/src/helpers/helpers.dom.ts +++ b/src/helpers/helpers.dom.ts @@ -142,7 +142,7 @@ function getContainerSize(canvas: HTMLCanvasElement, width: number, height: numb let maxWidth: number, maxHeight: number; if (width === undefined || height === undefined) { - const container = _getParentNode(canvas); + const container = canvas && _getParentNode(canvas); if (!container) { width = canvas.clientWidth; height = canvas.clientHeight; diff --git a/src/platform/platform.dom.js b/src/platform/platform.dom.js index 6c4b96d7546..4c6f72e425e 100644 --- a/src/platform/platform.dom.js +++ b/src/platform/platform.dom.js @@ -383,7 +383,7 @@ export default class DomPlatform extends BasePlatform { * @param {HTMLCanvasElement} canvas */ isAttached(canvas) { - const container = _getParentNode(canvas); + const container = canvas && _getParentNode(canvas); return !!(container && container.isConnected); } }