refactor: type aliasing ssh types #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
aymanbagabas
approved these changes
Nov 16, 2022
toby
approved these changes
Nov 16, 2022
Merged
caarlos0
added a commit
that referenced
this pull request
Nov 22, 2022
* Revert "fix: using our ssh fork (#95)" This reverts commit a14cf6d. * Revert "refactor: type aliasing ssh types (#94)" This reverts commit f7f0c95. * feat: using our fork Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com> Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow us to more easily use a fork of
gliderlabs/sshwhen needed (e.g. a pending PR), and also our users don't need to worry about whichsshto import (golang.org/x/crypto/sshvsgithub.com/gliderlabs/ssh.I took care to only use
github.com/gliderlabs/sshintypes.go,wish.goand thetestsessionstuff to avoid cyclic imports.I also changed the
gosshimports where I could to simplify things.