Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better authorized_keys parsing #81

Merged
merged 1 commit into from Oct 28, 2022
Merged

fix: better authorized_keys parsing #81

merged 1 commit into from Oct 28, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 28, 2022 •
edited

  • ignores empty lines
  • ignores commented lines (beginning with '#')

@caarlos0
fix: better authorized_keys parsing
90c274b 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label Oct 28, 2022
@caarlos0 caarlos0 marked this pull request as ready for review October 28, 2022 00:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022 •
edited

Codecov Report

Merging #81 (90c274b) into main (61ca856) will increase coverage by 0.52%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   71.79%   72.32%   +0.52%     
==========================================
  Files          18       18              
  Lines         897      896       -1     
==========================================
+ Hits          644      648       +4     
+ Misses        200      195       -5     
  Partials       53       53
Impacted Files Coverage Δ
bubbletea/tea.go 0.00% <0.00%> (ø)
options.go 80.35% <100.00%> (+0.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 9f2a257 into main Oct 28, 2022
@caarlos0 caarlos0 deleted the authorized_keys branch October 28, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maaslalani maaslalani maaslalani approved these changes

@aymanbagabas aymanbagabas Awaiting requested review from aymanbagabas aymanbagabas is a code owner

@toby toby Awaiting requested review from toby

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@caarlos0 @codecov-commenter @maaslalani @toby @aymanbagabas