Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EOL when force-closing the connection #50

Merged
merged 3 commits into from Jun 15, 2022
Merged

fix: EOL when force-closing the connection #50

merged 3 commits into from Jun 15, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jun 6, 2022

It seems that forcing an early session.Exit might cause formatting issues if a \r is not printed as well.

I'm not sure why this happens, but this seems to fix it.

Screenshot of the problem happening:

image

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Jun 6, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 marked this pull request as ready for review June 15, 2022 17:09
@caarlos0 caarlos0 merged commit c7c99ee into main Jun 15, 2022
@caarlos0 caarlos0 deleted the eol branch June 15, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants