Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scp bug when copying / #104

Merged
merged 1 commit into from Nov 30, 2022
Merged

fix: scp bug when copying / #104

merged 1 commit into from Nov 30, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 30, 2022

if you had your root folder to /foo/bar, and ran scp host:/ /tmp/, it would create a /tmp/bar folder, which it shouldn't.

@caarlos0 caarlos0 self-assigned this Nov 30, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Nov 30, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 marked this pull request as ready for review November 30, 2022 13:53
@codecov-commenter
Copy link

Codecov Report

Merging #104 (d919714) into main (d501f49) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   72.50%   72.65%   +0.14%     
==========================================
  Files          18       18              
  Lines         913      918       +5     
==========================================
+ Hits          662      667       +5     
  Misses        197      197              
  Partials       54       54              
Impacted Files Coverage Δ
scp/filesystem.go 90.32% <100.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 0e4e2e5 into main Nov 30, 2022
@caarlos0 caarlos0 deleted the fix-scp branch November 30, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants