Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: announce patches #100

Merged
merged 3 commits into from Nov 29, 2022
Merged

chore: announce patches #100

merged 3 commits into from Nov 29, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 21, 2022

announce releases

refs charmbracelet/meta#63

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Nov 21, 2022
@caarlos0
Copy link
Member Author

@aymanbagabas do you know if we need to map secrets like we do with goreleaser token et al?

if so, I need to change some things around in charmbracelet/meta#63

@caarlos0 caarlos0 added the enhancement New feature or request label Nov 21, 2022
@aymanbagabas
Copy link
Member

@aymanbagabas do you know if we need to map secrets like we do with goreleaser token et al?

if so, I need to change some things around in charmbracelet/meta#63

Ugh, we need to map the secrets in the goreleaser workflow in every repository. The secrets property in meta refers to the secret inputs NOT the global secret store because the workflow in meta is a workflow_call :/

@caarlos0
Copy link
Member Author

ah, figures, ight, will do that

@caarlos0
Copy link
Member Author

charmbracelet/meta#64

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 marked this pull request as ready for review November 21, 2022 19:13
.github/workflows/goreleaser.yml Outdated Show resolved Hide resolved
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #100 (4a271a0) into main (0857eb6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   71.98%   71.98%           
=======================================
  Files          18       18           
  Lines         903      903           
=======================================
  Hits          650      650           
  Misses        200      200           
  Partials       53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit d501f49 into main Nov 29, 2022
@caarlos0 caarlos0 deleted the announce branch November 29, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants