Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji Support #395

Open
sslivkoff opened this issue Oct 17, 2023 · 2 comments
Open

Emoji Support #395

sslivkoff opened this issue Oct 17, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@sslivkoff
Copy link

Hi. vhs is a joy to use. However one of the emojis in my program does not output properly.

Is your feature request related to a problem? Please describe.
Some emojis are supported but not others. I don't know the underlying cause

⏳ does work
⌛ does not work, instead showing up as a unicode emoji

image

Describe the solution you'd like
⌛ shows up in the output

@sslivkoff sslivkoff added the enhancement New feature or request label Oct 17, 2023
@PThorpe92
Copy link

This is actually going to depend on what font you choose, I don't believe it has anything to do with VHS itself.

Make sure you select a font that supports the latest NerdFont (3) and it should work

@mikelorant
Copy link
Contributor

This issue has been resolved by updating to the latest release of ttyd. On a Mac you can do:

brew install ttyd --HEAD

For those wondering, this was caused by xterm.js supporting only Unicode 6.

I added the xterm.js addon for Unicode 11 to ttyd.
tsl0922/ttyd#1310

Grapheme cluster support is coming to xterm.js but is currently experimental. This would have gotten us to Unicode 15, so for now this is as far as we can go.

No changes to VHS are necessary, however next time an official VHS container is built, it will also include the updated release of ttyd with these improvements.

@maaslalani Please mark this issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants