Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Value method #66

Merged
merged 2 commits into from Feb 14, 2022
Merged

Add Value method #66

merged 2 commits into from Feb 14, 2022

Conversation

76creates
Copy link
Contributor

Simple method for checking the value of the style set with SetString. This would be useful when creating conditionals for passed style objects.

@muesli muesli added the enhancement New feature or request label Feb 13, 2022
@muesli
Copy link
Member

muesli commented Feb 13, 2022

I know this isn't entirely consistent with the rest of the operations in borders.go and get.go, but I think this should just be called Value (no Get prefix), as there's no operation involved.

cc @meowgorithm

@meowgorithm
Copy link
Member

Agreed, Value is the way to go here.

@muesli muesli changed the title Add GetValue method Add Value method Feb 14, 2022
@muesli muesli merged commit 0a77f63 into charmbracelet:master Feb 14, 2022
@muesli
Copy link
Member

muesli commented Feb 14, 2022

Thank you @76creates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants