Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border size computations look wrong #112

Open
knz opened this issue Sep 3, 2022 · 0 comments
Open

Border size computations look wrong #112

knz opened this issue Sep 3, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@knz
Copy link

knz commented Sep 3, 2022

  1. GetBorderTopSize and GetBorderBottomSize returns the maximum rune width of all the border characters.
    This is wrong: the top/bottom border sizes are just 1 (1 line)

  2. GetBorderLeftSize and GetBorderRightSize are using maxRuneWidth() on every part, but they should use runewidth.StringWidth() instead.

Found while working on #109
@knz knz mentioned this issue Sep 3, 2022
Open
@muesli muesli added the bug Something isn't working label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@muesli @knz