feat: kill the program and restore terminal state #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aymanbagabas
commented
Feb 4, 2022
•
aymanbagabas
commented
- Add Kill() to force kill the program from the outside
- Prevent renderer channel from being closed multiple times
meowgorithm
approved these changes
Feb 4, 2022
muesli
reviewed
Feb 5, 2022
aymanbagabas
force-pushed
the
kill-program
branch
from
df41669
to
5c82c0c
Compare
muesli
approved these changes
Feb 7, 2022
* Add Kill() to force kill the program from the outside * Prevent renderer channel from being closed multiple times
aymanbagabas
force-pushed
the
kill-program
branch
from
5c82c0c
to
3b65b2c
Compare
meowgorithm
approved these changes
Feb 8, 2022
|
Nicely done, @aymanbagabas. |
lorenzo-milicia
pushed a commit
to lorenzo-milicia/bubbles
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.