Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tea.Batch returns nil if all cmds are nil #217

Merged
merged 1 commit into from Feb 3, 2022
Merged

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Feb 3, 2022

a different approach to #200

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Feb 3, 2022
@caarlos0 caarlos0 self-assigned this Feb 3, 2022
Copy link
Member

@muesli muesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Appreciate the tests!

@caarlos0 caarlos0 merged commit 9a06319 into master Feb 3, 2022
@caarlos0 caarlos0 deleted the batch-nil branch February 3, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants