New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support multi-byte strings on Windows #343
Conversation
Hey @mattn! Nice seeing you over here! Your contribution looks great, but I'm a bit puzzled about the If you don't mind, I could revert the formatting changes, so we can focus on reviewing the actual change. Thanks again! |
Ah, it seems that specification of |
Hmm, at least, same result in go1.18. |
I'll make this changes again. |
gofmt is changed |
Understood! This seems to be a pending change for 1.19, tho? Can't reproduce it with 1.18.3 for what it's worth. I think we should stick to the existing format until this gofmt change is part of a stable Go release. |
Reverted format |
I can squash this changes. Do you want? |
Thanks, but no need to, can do that here just fine! |
Small note that this will close #393. |
7cfff9a
to
0976d0e
Compare
Thank you so much for the contribution, @mattn. Multi-byte support is really important to us. Cheers 🍻. |
On Windows, it use double-byte character sets not UTF-8. So ReadFile return DBCS bytes. it should be converted to UTF-8.