Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(exec): small API edits #323

Merged
merged 4 commits into from Jun 2, 2022
Merged

chore(exec): small API edits #323

merged 4 commits into from Jun 2, 2022

Conversation

meowgorithm
Copy link
Member

@meowgorithm meowgorithm commented Jun 1, 2022

Small ergonomic edits to the long-awaited exec API. After this we should be good to do a release.

The tl;dr here is that we've added a helper command for running Exec on an exec.Cmd and, in turn, removed WrapCommand.

// Before
cmd := tea.Exec(tea.WrapCommand(c), fn)

// After
cmd := tea.ExecProcess(c, fn)

Side note: I did most of this over the weekend whilst at the dog groomer’s office.

@meowgorithm meowgorithm requested a review from caarlos0 June 1, 2022 23:52
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks neat!

@meowgorithm meowgorithm merged commit 775dbfb into master Jun 2, 2022
@meowgorithm meowgorithm deleted the exec-edits branch June 2, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants