Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve godoc on tick and every #320

Merged
merged 5 commits into from May 30, 2022
Merged

docs: improve godoc on tick and every #320

merged 5 commits into from May 30, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented May 23, 2022

This is always a source of confusion. Thought it would be worth to make it as clearer as possible, not sure if I got it to that point, happy to have some feedback :)

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this May 23, 2022
@caarlos0 caarlos0 added the documentation Improvements or additions to documentation label May 23, 2022
@caarlos0 caarlos0 marked this pull request as ready for review May 23, 2022 19:41
@caarlos0 caarlos0 requested a review from bashbunni May 23, 2022 19:41
@bashbunni
Copy link
Member

That looks great! I think that'll help to clarify

caarlos0 and others added 2 commits May 25, 2022 09:39
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@meowgorithm
Copy link
Member

This is really apt. @caarlos0, I reworded stuff a bit and added an example: lmk what you think.

@caarlos0
Copy link
Member Author

looks amazing, thanks @meowgorithm

@caarlos0 caarlos0 merged commit 9705056 into master May 30, 2022
@meowgorithm meowgorithm deleted the docs-every branch May 30, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants