Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): update keybindings when setting items #90

Merged
merged 2 commits into from Jan 11, 2022

Conversation

paralin
Copy link
Contributor

@paralin paralin commented Jan 3, 2022

Bug: when calling SetItems when items was previously empty, the keybindings for
up/down do not appear.

Fix: call updateKeybindings in SetItems.

Signed-off-by: Christian Stewart <christian@paral.in>
Bug: when calling SetItems when items was previously empty, the keybindings for
up/down do not appear.

Fix: call updateKeybindings in SetItems.

Signed-off-by: Christian Stewart <christian@paral.in>
@meowgorithm
Copy link
Member

Good catch! This generally looks right. We’ll merge once we verify. Thanks for the PR!

@paralin
Copy link
Contributor Author

paralin commented Jan 5, 2022

@meowgorithm after extensive testing I can confidently say this was the fix.

@meowgorithm
Copy link
Member

meowgorithm commented Jan 10, 2022

Thanks so much, @paralin. Would it be possible to provide some sample code we could use to verify the fix with over here? This will help us accelerate getting this ticket merged.

@paralin
Copy link
Contributor Author

paralin commented Jan 10, 2022

@meowgorithm just create a bubbles list of length 0, then call AddItem to add an item (in Update).

@meowgorithm meowgorithm added the bug Something isn't working label Jan 11, 2022
@meowgorithm meowgorithm merged commit 5f256bf into charmbracelet:master Jan 11, 2022
@meowgorithm
Copy link
Member

Thanks so much for the fix!

@paralin
Copy link
Contributor Author

paralin commented Jan 11, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants