Fix bug where viewport doesn't render final lines #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This previously went unnoticed because we all seemed to have newlines at the end of our viewport input. This update introduces the Model.SetYOffset method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes a bug where final lines wouldn't be rendered in viewports when doing standard (non-performance) rendering. I supposed we never noticed this because many of our files and strings tended to have a final newline (in the latter case, perhaps to work around the bug).
This update also contains a fix where the performance renderer could consume one line too many if the y-position of the viewport was greater than
0.This update also introduces a method for setting a viewport's y-offset,
Model.ViewSetYOffset(int), which contains some safeguards for keeping the y-offset in bounds.In a future release, the
Model.YOffsetmember, anint, will be replaced with a getter.Fixes #73.