Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

key: string-based parsing is inefficient #262

Open
knz opened this issue Oct 2, 2022 · 0 comments · May be fixed by #261
Open

key: string-based parsing is inefficient #262

knz opened this issue Oct 2, 2022 · 0 comments · May be fixed by #261

Comments

@knz
Copy link
Contributor

knz commented Oct 2, 2022

Every time a bubble calls key.Matches the key is rendered as a string and then the string is compared.
This is inefficient, and also the heap allocation (1 for each case in the switch!) creates noise in the go GC.
@knz knz linked a pull request Oct 2, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

key: optimize Matches knz/bubbles
1 participant
@knz