Upgrade to toml v0.5.11

[charliermarsh]

In #1680, we moved over to toml_edit. But it looks like toml now uses toml_edit, and has implemented some improvements (e.g., this closes #1894).

[charliermarsh]

\cc @messense

[messense]

Looks like the released version on crates.io doesn’t use toml_edit currently: https://crates.io/crates/toml/0.5.11/dependencies

[charliermarsh]

Oh, strange. Any idea what the state of the crate is? Should I revert this?

[messense]

Only toml released a new version without any noticeable behavior changes, toml_edit is still on 0.17.1 which doesn't resolve the issue.

Should I revert this?

For now you can revert it to be more compliant with TOML 1.0. At least a new toml_edit release a required for #1894.

Or we can just depends on toml main branch using git dependency?

[charliermarsh]

Interesting, I did run through the example described in that issue and it seemed to work with the new crate. Is that unexpected?

[charliermarsh]

@messense - It looks like v0.5.11 was mostly about deprecations in advance of the toml-edit migration. I am confused though why this now works:

[tool.hatch]
version.source = "vcs"

[tool.hatch.version.raw-options]
local_scheme = "no-local-version"

So, I might leave it as-is for now? Is that bad? What did we lose by not supporting TOML 1.0?

[messense]

It still fails for me?

cargo run
   Compiling toml-test v0.1.0 (/private/tmp/toml-test)
    Finished dev [unoptimized + debuginfo] target(s) in 0.16s
     Running `target/debug/toml-test`
Err(
    Error {
        inner: ErrorInner {
            kind: Custom,
            line: Some(
                5,
            ),
            col: 0,
            at: Some(
                55,
            ),
            message: "duplicate key: `version`",
            key: [
                "tool",
                "hatch",
            ],
        },
    },
)

Cargo.toml

[package]
name = "toml-test"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
toml = "0.5.11"

src/main.rs

fn main() {
    let content = r#"# pyproject.toml

[tool.hatch]
version.source = "vcs"

[tool.hatch.version.raw-options]
local_scheme = "no-local-version""#;
    println!("{:#?}", toml::from_str::<toml::Value>(content));
}

[charliermarsh]

Interesting, let me try again in the morning.

[charliermarsh]

Yeah I can reproduce that, but interestingly, this works fine:

let content = r#"# pyproject.toml

[tool.hatch]
version.source = "vcs"

[tool.hatch.version.raw-options]
local_scheme = "no-local-version""#;

println!("{:#?}", toml::from_str::<Pyproject>(content));