Implement flake8-simplify SIM105 rule #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how to implement autofix and proper error span yet, still learning😅 |
messense
force-pushed
the
flake8-simplify-sim105
branch
from
9b5e10a
to
4ea61cc
Compare
| handler_names.join(", ") | ||
| }; | ||
| let check = Check::new( | ||
| CheckKind::UseContextlibSuppress(exception), |
There was a problem hiding this comment.
This might be a hard one to autofix right now because it depends on contextlib being imported already.
messense
force-pushed
the
flake8-simplify-sim105
branch
from
4ea61cc
to
0e42ace
Compare
messense
force-pushed
the
flake8-simplify-sim105
branch
from
0e42ace
to
4e96b09
Compare
|
Thank you! |
renovate bot
added a commit
to ixm-one/pytest-cmake-presets
that referenced
this pull request
Jan 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.210` -> `^0.0.211` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.211`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.211) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.210...v0.0.211) #### What's Changed - Implement `SIM220` and `SIM221` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1630 - Implement flake8-simplify SIM105 rule by [@​messense](https://togithub.com/messense) in [astral-sh/ruff#1621 - Fix `SIM105` by [@​harupy](https://togithub.com/harupy) in [astral-sh/ruff#1633 - Adding my company to the "used in" category of the Readme. by [@​colin99d](https://togithub.com/colin99d) in [astral-sh/ruff#1631 - Implement flake8-bandit rule `S103` by [@​edgarrmondragon](https://togithub.com/edgarrmondragon) in [astral-sh/ruff#1636 - Rename flake8-bandit rules from plugins to checks by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1637 - Tweak Yoda condition message by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1638 - Note a few more incompatibilities by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1639 - Add task-tags & ignore-overlong-task-comments settings by [@​not-my-profile](https://togithub.com/not-my-profile) in [astral-sh/ruff#1550 - Add badge JSON by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1641 - Add Ruff badge to README by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1642 - DRY up unused import removal code by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1643 - Implement builtin import removal by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1645 - Move external licenses to separate directory by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1648 - Implement nested-if detection by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1649 - Implement flake8-bandit rule `S108` by [@​edgarrmondragon](https://togithub.com/edgarrmondragon) in [astral-sh/ruff#1644 - Implement nested with detection (SIM117) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1651 - Cancel outdated in-progress workflow automatically by [@​messense](https://togithub.com/messense) in [astral-sh/ruff#1652 - Implement flake8-simplify SIM107 by [@​messense](https://togithub.com/messense) in [astral-sh/ruff#1650 - Implement `SIM110` and `SIM111` (conversion to `any` and `all`) by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#1653 **Full Changelog**: astral-sh/ruff@v0.0.210...v0.0.211 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44MS4wIiwidXBkYXRlZEluVmVyIjoiMzQuODEuMCJ9--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #998